Generate Equality Check for entities #799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add in the generator the code to generate equality checks (method
=
andhash
).We keep the current default behavior -> no breaking change possible :)
I propose adding a method named:
withEqualityCheckOn:
that takes the list of properties as input to check for equality.It then generates the
=
andhash
methods considering this list.I have modified
FamixTest4Generator
to take into consideration this update.For instance, I added to
person
a firstName and lastName. And I added the quality check on themThe same for book with an
id
I update the setup to add identity information. And I added the test
testEqualityStudent
to particularly test this featureFor method
=
The generation follows this pattern:
And for
hash
I based this template on existing methods in the system