Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #displayFullString to have an equivalent of #mooseName also usefu… #779

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Jun 3, 2024

…l for associations

@jecisc jecisc merged commit 0d2bcab into development Jun 3, 2024
3 of 4 checks passed
@jecisc jecisc deleted the display-full branch June 3, 2024 15:04
@NicolasAnquetil
Copy link
Contributor

Not sure I got it.
What's wrong with mooseName ? Why duplicate it ?

@jecisc
Copy link
Member Author

jecisc commented Jun 4, 2024

We have #mooseName returning the name of the entity and the containment but for associations it returns #noname.
We have #displayString returning the name without the containment, and prints the source and target for associations but it does not print the containment.

In FamixDiff result we want to see the containment because when you have 10 #readObject method you need to find easily in which class/package they are. And you want a nice display for associations also. (This is feedback from Imen)

So I cannot use either of those two methods. I discussed with Clotilde and Anne. I first proposed to change the moose name of associations to print sources and target but Anne do not think this is right. So the solution we chose is to introduce a new variation of the printing method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants