Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should file importers be in MooseIDE ? #728

Closed
jecisc opened this issue Feb 26, 2024 · 2 comments · Fixed by #731
Closed

Should file importers be in MooseIDE ? #728

jecisc opened this issue Feb 26, 2024 · 2 comments · Fixed by #731
Assignees
Labels
question Further information is requested

Comments

@jecisc
Copy link
Member

jecisc commented Feb 26, 2024

Currently the MSE and JSON file importers are in MooseIDE. I am wondering if it would not make sense for them to be in Famix instead since they are more models entities than view entities?

@jecisc jecisc added the question Further information is requested label Feb 26, 2024
@NicolasAnquetil
Copy link
Contributor

makes sense to me
we had a discussion on this with @fuhrmanator recently

@jecisc
Copy link
Member Author

jecisc commented Feb 28, 2024

For information, I also moved some behavior to detect the right model for an importer and a file to import from the presenters to the importers. Like this I can reuse it for the Software Heritage importer and this can help other people I guess

jecisc added a commit that referenced this issue Mar 13, 2024
This PR moves the MSE importer and JSONImporter from MooseIDE to Famix.

Fixes #728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants