-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pallet-xcm precompile to Moonbeam and Moonriver (transfer_assets_using_type_and_then
extrinsic support)
#2992
Conversation
transfer_assets_using_type_and_then
extrinsic support)
WASM runtime size check:Compared to target branchMoonbase runtime: 2292 KB (no changes) ✅ Moonbeam runtime: 2268 KB (no changes) ✅ Moonriver runtime: 2260 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2292 KB (+332 KB compared to latest release) Moonbeam runtime: 2268 KB (+344 KB compared to latest release) Moonriver runtime: 2260 KB (+336 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master agustin-xcm-transfer-assets-using +/- ##
====================================================================
Coverage 79.12% 79.12% 0.00%
Files 303 303
+ Lines 88015 88017 +2
====================================================================
Hits 69637 69637
+ Misses 18378 18380 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me
@Agusrodri Do we need to change any benchmarks? |
@RomarQ I don't think we need to change benchmarks itself. Although, I noticed that we don't have weights for |
|
What does it do?
This PR adds support for pallet-xcm precompile in both Moonbeam and Moonriver runtimes.
It also updates the moonkit's pin to include the most recent changes of the precompile, related to the new feature of using
transfer_assets_using_type_and_then
extrinsic through the precompile.Related Moonkit PR
transfer_assets_using_type_and_then
extrinsic in pallet-xcm precompile Moonsong-Labs/moonkit#54