fix unfairness on proof size check estimation #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadkaouk
added
B7-runtimenoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2280 KB (no changes) ✅ Moonbeam runtime: 2236 KB (no changes) ✅ Moonriver runtime: 2256 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2280 KB (+320 KB compared to latest release) Moonbeam runtime: 2236 KB (+312 KB compared to latest release) Moonriver runtime: 2256 KB (+332 KB compared to latest release) |
librelois
reviewed
Sep 13, 2024
ahmadkaouk
added
D3-trivial
librelois
previously approved these changes
Sep 13, 2024
noandrea
changed the title
Coverage Report@@ Coverage Diff @@
## master ahmad-evm-native-transfer-test +/- ##
==================================================================
- Coverage 79.13% 79.12% -0.01%
Files 303 303
- Lines 88050 88015 -35
==================================================================
- Hits 69675 69637 -38
+ Misses 18375 18378 +3
|
RomarQ
approved these changes
Oct 3, 2024
RomarQ
reviewed
Oct 3, 2024
RomarQ
previously requested changes
Oct 3, 2024
librelois
previously approved these changes
Oct 3, 2024
librelois
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It points frontier and moonbeam to the latest pin in stable, which includes this commit.
What important points reviewers should know?
batch_not_callable_by_smart_contractwas removed because the same functionality is covered bybatch_is_not_callable_by_dummy_codeIs there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?