Divide ref time XCM fees by four #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B7-runtimenoteworthy
librelois
changed the title
WASM runtime size check:Compared to target branchMoonbase runtime: 2180 KB (no changes) ✅ Moonbeam runtime: 2120 KB (no changes) ✅ Moonriver runtime: 2116 KB (no changes) ✅ Compared to latest release (runtime-3101)Moonbase runtime: 2180 KB (+2180 KB compared to latest release) Moonbeam runtime: 2120 KB (+144 KB compared to latest release) Moonriver runtime: 2116 KB (+2116 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master elois-divide-xcm-cost-by-2 +/- ##
=============================================================
Coverage 80.92% 80.92% 0.00%
Files 286 286
+ Lines 81804 81813 +9
=============================================================
+ Hits 66196 66205 +9
Misses 15608 15608
|
|
Changes to |
RomarQ
approved these changes
Sep 4, 2024
noandrea
pushed a commit
that referenced
this pull request
Sep 5, 2024
* divide by 2 xcm fees * divide by 4 xcm fees * try to fix rust tests * fix dev tests including the hardcoded constant * fix remaining constant in xcm dev test * update expected values to ~/4 the previous ones --------- Co-authored-by: Pablo Labarta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Since we have 4 times more cpu time per block, we need to divide as well the xcm fees constant that account for cpu time
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?