Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State Trie Migration v1 #2907

Merged
merged 68 commits into from
Oct 1, 2024
Merged

State Trie Migration v1 #2907

merged 68 commits into from
Oct 1, 2024

Conversation

TarekkMA
Copy link
Contributor

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@TarekkMA TarekkMA changed the title WIP State Trie Migration v2 WIP State Trie Migration v1 Aug 20, 2024
@RomarQ
Copy link
Contributor

RomarQ commented Aug 22, 2024

Some considerations about state tree migration can be found here: https://forum.polkadot.network/t/state-trie-migration/852/

@noandrea noandrea added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes labels Aug 23, 2024
Copy link
Contributor

github-actions bot commented Aug 27, 2024

Coverage Report

@@                     Coverage Diff                      @@
##           master   tarekkma/state_migration      +/-   ##
============================================================
+ Coverage   79.18%                     79.23%   +0.05%     
  Files         299                        299              
+ Lines       87226                      87602     +376     
============================================================
+ Hits        69065                      69405     +340     
+ Misses      18161                      18197      +36     
Files Changed Coverage
/pallets/moonbeam-lazy-migrations/src/lib.rs 83.54% (-8.77%) 🔽
/pallets/moonbeam-lazy-migrations/src/tests.rs 99.55% (-0.45%) 🔽
/runtime/common/src/migrations.rs 72.33% (+0.13%) 🔼

Coverage generated Mon Sep 30 23:23:10 UTC 2024

Copy link
Contributor

github-actions bot commented Aug 27, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2188 KB (no changes) ✅

Moonbeam runtime: 2148 KB (no changes) ✅

Moonriver runtime: 2148 KB (no changes) ✅

Compared to latest release (runtime-3200)

Moonbase runtime: 2188 KB (+228 KB compared to latest release) ⚠️

Moonbeam runtime: 2148 KB (+224 KB compared to latest release) ⚠️

Moonriver runtime: 2148 KB (+224 KB compared to latest release) ⚠️

runtime/moonbase/src/lib.rs Outdated Show resolved Hide resolved
librelois
librelois previously approved these changes Sep 13, 2024
@pLabarta
Copy link
Contributor

State version upgrade breaks our Zombienet tests because local chainspecs are always generated using the native runtime. There is no easy way to fix this issue, but since changes do not impact the client, we can opt to use the latest release client for this particular upgrade test.

After 3300 is released, Zombienet tests should be changed back and work as expected with the branch built client.

librelois
librelois previously approved these changes Sep 30, 2024
@RomarQ RomarQ merged commit 4c20e1e into master Oct 1, 2024
39 checks passed
@RomarQ RomarQ deleted the tarekkma/state_migration branch October 1, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants