trace_filter RPC #288
Merged
trace_filter RPC #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock # Cargo.toml # node/rpc/Cargo.toml # node/standalone/Cargo.lock
# Conflicts: # Cargo.lock # Cargo.toml # node/rpc/Cargo.toml # node/rpc/src/lib.rs # node/standalone/Cargo.lock # runtime/Cargo.toml # runtime/src/lib.rs
# Conflicts: # Cargo.lock # Cargo.toml # client/rpc-core/txpool/Cargo.toml # client/rpc/txpool/Cargo.toml # node/Cargo.toml # node/rpc/Cargo.toml # node/src/rpc.rs # node/src/service.rs # node/standalone/Cargo.lock # node/standalone/Cargo.toml # node/standalone/src/command.rs # node/standalone/src/service.rs # primitives/rpc/txpool/Cargo.toml # runtime/Cargo.toml # runtime/account/Cargo.toml # runtime/precompiles/Cargo.toml # runtime/precompiles/src/lib.rs # runtime/src/lib.rs
# Conflicts: # Cargo.lock # node/Cargo.toml # node/src/rpc.rs # node/src/service.rs # runtime/Cargo.toml # runtime/account/Cargo.toml # runtime/precompiles/Cargo.toml
JoshOrndorff
reviewed
Apr 1, 2021
There was a problem hiding this comment.
Looks good to the extent I can assess it. Could use review from @tgmichel
crystalin
reviewed
Apr 1, 2021
crystalin
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds trace_filter RPC endpoint, with a background task to keep a cache of the traces to avoid redundant computations.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?
Checklist