-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt xcm-utils to XCM V3 #2304
Conversation
Coverage generated "Mon May 22 22:36:20 UTC 2023": Master coverage: 72.45% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great coverage, just added some comments on making the helpers more helpful, and some Polkadot.js best practises. A lot of the comments are duplicates but that's just to help the refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please tests the existing V2 instructions in V3, especially DepositAsset
* first attempt * progress * added new instructions to fragment * add more instructions (draft) * add remaining xcmv3 instructions * split files and fmt * delete files * refactor of some files * add comments * refactor code and parameterize with new interfaces * add default case in expect * remove unused imports * add tests for existing v2 instructions --------- Co-authored-by: timbrinded <[email protected]>
What does it do?
This PR performs the adaptation of
xcm-utils
(used in typescript tests) to work well with XCM V3, adding the new instructions and modifying the previous necessary ones for them to behave properly with V3.