Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizes MigrateAtStakeAutoCompound to run only for unpaid rounds #1881

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Optimizes MigrateAtStakeAutoCompound to run only for unpaid rounds #1881

merged 2 commits into from
Oct 20, 2022

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Oct 20, 2022

What does it do?

  • Removes RemovePaidRoundsFromAtStake migration, which would be performed manually due to the high PoV size.
  • Runs MigrateAtStakeAutoCompound only for last N unpaid rounds defined by RewardPaymentDelay.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@nbaztec nbaztec added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Oct 20, 2022
@librelois librelois mentioned this pull request Oct 20, 2022
Closed
24 tasks
@nbaztec nbaztec merged commit c82b191 into master Oct 20, 2022
@nbaztec nbaztec deleted the nish-auto-compound-migrate-lite branch October 20, 2022 12:13
@crystalin crystalin changed the title Run MigrateAtStakeAutoCompound only for unpaid rounds Optomize MigrateAtStakeAutoCompound to run only for unpaid rounds Oct 20, 2022
@crystalin crystalin changed the title Optomize MigrateAtStakeAutoCompound to run only for unpaid rounds Optomizes MigrateAtStakeAutoCompound to run only for unpaid rounds Oct 20, 2022
@crystalin crystalin changed the title Optomizes MigrateAtStakeAutoCompound to run only for unpaid rounds Optimizes MigrateAtStakeAutoCompound to run only for unpaid rounds Oct 21, 2022
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Dec 14, 2022
@sea212 sea212 mentioned this pull request Jan 5, 2023
Merged
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@nbaztec @imstar15
Run MigrateAtStakeAutoCompound only for unpaid rounds (moonbeam-found…
6760312 
…ation#1881)

* remove RemovePaidRoundsFromAtStake migration, run MigrateAtStakeAutoCompound only for unpaid rounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@librelois librelois librelois approved these changes

Assignees
No one assigned
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbaztec @librelois @notlesh