v0.9.18 deps update #1372
Merged
v0.9.18 deps update #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@notlesh xtokens tests are fixed, I also pointed at a new commit of frontier because the node wasnt building for me, I needed to pass the "with-codec" feature flag for the evm create in evm/primitives |
crystalin
approved these changes
Apr 1, 2022
girazoki
approved these changes
Apr 1, 2022
tgmichel
approved these changes
Apr 1, 2022
notlesh
added
B5-clientnoteworthy
notlesh
commented
Apr 1, 2022
librelois
reviewed
Apr 1, 2022
| @@ -655,6 +662,10 @@ where | |||
| relay_chain_interface, | |||
| relay_chain_slot_duration, | |||
| import_queue, | |||
| // TODO: plumb this through CLI properly | |||
| collator_options: CollatorOptions { | |||
| relay_chain_rpc_url: Default::default(), | |||
There was a problem hiding this comment.
@notlesh does this mean that we can't really test --relay-chain-rpc-url yet ? It matters, because @crystalin wanted us to start testing this feature.
There was a problem hiding this comment.
I'll follow up with a new PR. It shouldn't be difficult.
Haven't tried yet, but it would be great to move off of our custom branch. That could be a quick PR after this, though ;) |
notlesh
added
D1-audited👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Updates to Substrate v0.9.18.
Brief status update: I have the runtimes building with an override for
evmto point to the unreleasedv0.35.0version.moonbeams node needs some work.nimbusneeds some work around itsparachain-template, although that may not be necessary to make progress for now.