Remove MongoDB #165
Merged
Remove MongoDB #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This issue is based on #163 |
andrewnicols
force-pushed
the
remove_old_deps
branch
3 times, most recently
from
4ca41f9 to
f5dc26d
Compare
|
Note: I considered removing the memcached extension too, but opted not to because memcached actually has a usage, whilst mongodb is fricking useless in our case. |
andrewnicols
force-pushed
the
remove_old_deps
branch
from
f5dc26d to
31c3c1e
Compare
This change makes it much faster to make smaller changes to the image by: - moving the ADD commands to more targeted additions in order of build size - breaking out the Oracle and sqlsrv builds into their own ADD and RUN sections in the Dockerfile - moving the addition of non build-related files to right at the end of the Dockerfile These changes mean that it is possible to more easily developer the image, for example: - you can now make changes to files within the /usr directory without recompiling all PHP extensions - you can now iterate on the Oracle and/or sqlsrv extensions without recompiling all PHP extensinos - you can now iterate on the sqlsrv extension, without recompiling all PHP extensions Whist this has little effect on the end image, or the build process within CI systems, local development is substantially improved (unless you're making changes to the php-extensions.sh script).
From Moodle 4.2 we no longer include MongoDB, and we add support for PHP 8.2 (or will do soon). Therefore we can drop the inclusion of the MongoDB extension *for PHP 8.2 and up only*.
andrewnicols
force-pushed
the
remove_old_deps
branch
from
31c3c1e to
3364ef3
Compare
|
Sold! (applying to the the 2 php82 images now...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes MongoDB from our build.
This change is only suitable for PHP 8.2, because older versions of PHP are used in older versions of Moodle where MongoDB still exists. We support MongoDB for Moodle 4.1 and older.