Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Selenium to version 4 #298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions bin/moodle-docker-compose
Original file line number Diff line number Diff line change
Expand Up @@ -136,18 +136,7 @@ fi

if [[ -z "$MOODLE_DOCKER_BROWSER_TAG" ]];
then
if [[ "$MOODLE_DOCKER_BROWSER_NAME" = "firefox" ]];
then
MOODLE_DOCKER_BROWSER_TAG=3
elif [[ "$MOODLE_DOCKER_BROWSER_NAME" = "chrome" ]];
then
if [[ "$MOODLE_DOCKER_APP_RUNTIME" = "ionic5" ]];
then
MOODLE_DOCKER_BROWSER_TAG=3
else
MOODLE_DOCKER_BROWSER_TAG="120.0"
fi
fi
MOODLE_DOCKER_BROWSER_TAG=4
fi

# Mobile app for development
Expand Down
13 changes: 2 additions & 11 deletions bin/moodle-docker-compose.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -100,20 +100,11 @@ IF NOT "%MOODLE_DOCKER_BROWSER%"=="" (
)

IF "%MOODLE_DOCKER_BROWSER_NAME%"=="" (
SET MOODLE_DOCKER_BROWSER_NAME=firefox
SET MOODLE_DOCKER_BROWSER_NAME=firefox
)

IF "%MOODLE_DOCKER_BROWSER_TAG%"=="" (
IF "%MOODLE_DOCKER_BROWSER_NAME%"=="firefox" (
SET MOODLE_DOCKER_BROWSER_TAG=3
)
IF "%MOODLE_DOCKER_BROWSER_NAME%"=="chrome" (
IF "%MOODLE_DOCKER_APP_RUNTIME%"=="ionic5" (
SET MOODLE_DOCKER_BROWSER_TAG=3
) ELSE (
SET MOODLE_DOCKER_BROWSER_TAG=120.0
)
)
SET MOODLE_DOCKER_BROWSER_TAG=4
)

IF "%MOODLE_DOCKER_BROWSER_NAME%"=="chrome" (
Expand Down
Loading