MDL-81951 changes to power levels #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits here:
The latest is just a correction to bring our mock's power levels inline with the Matrix defaults.
https://github.com/matrix-org/synapse/blob/v1.70.0/synapse/handlers/room.py#L1170-L1189
The other commit is more substantial. A new GET request is now possible when using the /v3/rooms/{roomID}/state/{eventType}/ route that allows the fetching of power levels.
Resolved in MDL-81591, we were fetching the power levels using sync, but I found that this would sometimes lag in its results and not always give up-to-the-second results. I created a new trait that used the m.room.power_levels endpoint with a GET request. The changes here reflect that.
IMPORTANT: This pull request will need to be accepted before the Moodle tracker issue MDL-81951 is integrated.