Skip to content

Commit

Permalink
Remove README notes about DH password
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewnicols committed Oct 24, 2022
1 parent caf0258 commit 87d85c1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/build_and_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,6 @@ jobs:
push: true
tags: ${{ steps.calculatetagsgcr.outputs.tags }}

# https://github.com/peter-evans/dockerhub-description
# It's horrible that we need to use password here instead of PAT, because
# that's only available via CLI what defeats 2FA. Anyway, we need to
# auto-update the description, so using it (till available via PAT).
# Link: https://github.com/peter-evans/dockerhub-description/issues/10
# Note that we only update the description with the main branch version.
- name: Set Docker Hub description from README.md
if: github.ref == 'refs/heads/main' && env.DOCKERHUB_OWNER != ''
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ Notes:
Note : if you want to publish on your own repository (being Docker Hub or Git Container Registry), you need to define the
following secrets [following secrets ](https://docs.github.com/en/actions/security-guides/encrypted-secrets):
* DOCKERHUB_OWNER
* DOCKERHUB_PASSWORD
* DOCKERHUB_TOKEN
* DOCKERHUB_USERNAME
* GH_OWNER
Expand Down

0 comments on commit 87d85c1

Please sign in to comment.