-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Migrate the Plugin_files page #69
Conversation
48dbd42
to
3fb08cc
Compare
d6fbe87
to
0cd99c0
Compare
This issue needs a bit of explaining. As I was moving some of the plugintype doumentation over I noticed that there is a lot of documentation relating to plugin files which is duplicated, or out-of-date. We often document files like To solve this I thought it would be useful to move these sections out into reusable templates, but then I realised that we sometimes want to specify extra information, differnt information, different examples, no examples, etc. To solve this I created a
We can use this data to create a consistent look and feel which is reusable. The default description of the file is provided in an mdx file. Additional descripton data can be added using the Likewise a default example can be provided, but this can be modified from a specific plugintype. Equally the
Likewise the Antivirus documentaiton wishes to specify a better example for its settings.php. This can be achieved with:
The standard description will beu sed, but the example filename will have the path In addition to this, the This means that we do a little bit of currying and provide a default version of the getter in the |
d50cb84
to
d02a985
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on this huge feature to simplify the creation of the plugin type pages! I think that's a great idea and, although the visualization can still be slightly improved, it's a very good improvement! Well done.
As you'll see, I've raised a few questions and sent some suggestions. Apart from that, I have one more comment, related to the way categories are displayed: as you can see in the following screenshot, content below each plugin type is not consistent (for instance, a couple of them are displaying the <Since xxx label):
I think I've resolved all but one of these appropriately. The final one is awaiting feedback from you re the question bank plugin type.
This is a bug in Docusaurus. I've asked on their Discord chat if there's an existing issue for it - waiting to hear back. I'll rebase my code now (some conflicts to resolve) and then I'll update the patch. |
d02a985
to
f990fd9
Compare
This change introduces a new set of utilities so that we can include the file examples across the docs and make them more specific each time, yet very consistent. Ideally we should update all existing uses we have (currently mod.md).
f990fd9
to
9b7c5ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.