Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for multiple flavour and child-theme related issues #792

Merged
merged 6 commits into from
Jan 2, 2025
Merged

Conversation

abias
Copy link
Member

@abias abias commented Jan 1, 2025

This PR fixes multiple flavour and child-theme related issues:

* 2024-12-31 - Child theme support: Fully replicate Boost Union's extra SCSS if a Boost Union Child theme is the current theme, resolves #718, resolves theme_boost_union_child/#5.
* 2024-12-31 - Bugfix / Child theme support: The theme_boost_union_get_pre_scss() and theme_boost_union_get_extra_scss() function used $theme->settings although they should not do that anymore, resolves #791
* 2024-12-31 - Tests: Increase the test coverage for the background image setting, helps to resolve theme_boost_union_child/#5
* 2024-12-31 - Bugfix: In flavours, not setting the brand color / bootstrap colors in a flavour did not result in the global brand color / bootstrap colors being served properly, resolves #790.
* 2024-12-30 - Improvement: Add more flavour settings (Activity icon colors, navbar color, background image position), resolves #789.

abias added 6 commits January 1, 2025 18:19
…n a flavour did not result in the global brand color / bootstrap colors being served properly, resolves #790.
…d theme_boost_union_get_extra_scss() function used ->settings although they should not do that anymore, resolves #791
…ost Union Child theme is the current theme, resolves #718, resolves theme_boost_union_child/#5.
@abias abias merged commit da60e3e into main Jan 2, 2025
12 checks passed
@abias abias deleted the issue-789 branch January 2, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant