Feature: Built-in imprint, solves #32 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abias
force-pushed
the
issue-32
branch
2 times, most recently
from
73a4719 to
b6ef5aa
Compare
lucaboesch
reviewed
Jul 7, 2022
There was a problem hiding this comment.
@abias I've got a huge backflash!
Remember "Change role" in Boost Campus?
I would suggest a third option, to satisfy all possible needs.
Do not automatically show a link to the imprint page
Add a link to the imprint page to the footnote
Add a link to the imprint page to the footer (questionmark) icon
Add a link to the imprint page to both the footnote and the footer (questionmark) icon
Do you see what I mean?
Best,
Luca
This patch allows the admin to enable a imprint page which can be filled with custom content. Additionally, the link to the imprint page can be added to the footnote or the footer automatically. This feature is particularly intended to be an easier-to-use replacement for local_staticpage and other third party solutions if you just need to add an imprint to your site.
|
Especially for you, I have added this fourth option now, Luca. |
lucaboesch
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
"Especially for you"!
We were young, then…
https://www.youtube.com/watch?v=aGuNsiSZ9RI
Jokes aside, the pull request looks spot on.
Merging.
detomon
pushed a commit
to detomon/moodle-theme_boost_union
that referenced
this pull request
Aug 26, 2024
…n/issue-32 Feature: Built-in imprint, solves moodle-an-hochschulen#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows the admin to enable a imprint page which can be filled with custom content.
Additionally, the link to the imprint page can be added to the footnote or the footer automatically.
This feature is particularly intended to be an easier-to-use replacement for local_staticpage and other third party solutions if you just need to add an imprint to your site.
Please note that this PR is built on top of PR #42 and should be merged in line.