Skip to content

Commit

Permalink
treewide: fix "could not merge expression" from gazelle
Browse files Browse the repository at this point in the history
This isn't any real bugfix, but more of a style thing. Gazelle can't work with select or glob statements (bazel-contrib/bazel-gazelle#1735), but will work fine with them and even ignore them if set to # keep. This adds that directive to make gazelle less verbose when running.

Change-Id: I7c638867d6b566e1d398eef37aff2316bf90a00f
Reviewed-on: https://review.monogon.dev/c/monogon/+/3241
Reviewed-by: Leopold Schabel <[email protected]>
Tested-by: Jenkins CI
  • Loading branch information
fionera committed Jul 24, 2024
1 parent 194c871 commit 93ba807
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cloud/apigw/model/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ sqlc_go_library(
name = "sqlc_model",
dialect = "cockroachdb",
importpath = "source.monogon.dev/cloud/apigw/model",
migrations = glob(["migrations/*sql"]),
migrations = glob(["migrations/*.sql"]),
queries = [
"queries.sql",
],
Expand All @@ -17,7 +17,7 @@ go_library(
embed = [
":sqlc_model", # keep
],
embedsrcs = glob(["migrations/*sql"]),
embedsrcs = glob(["migrations/*.sql"]), # keep
importpath = "source.monogon.dev/cloud/apigw/model",
visibility = ["//visibility:public"],
deps = [
Expand Down
4 changes: 2 additions & 2 deletions cloud/bmaas/bmdb/model/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ sqlc_go_library(
name = "sqlc_model",
dialect = "cockroachdb",
importpath = "source.monogon.dev/cloud/bmaas/bmdb/model",
migrations = glob(["migrations/*sql"]),
migrations = glob(["migrations/*.sql"]),
queries = [
"queries_base.sql",
"queries_stats.sql",
Expand All @@ -23,7 +23,7 @@ go_library(
embed = [
":sqlc_model", # keep
],
embedsrcs = glob(["migrations/*sql"]),
embedsrcs = glob(["migrations/*.sql"]), # keep
importpath = "source.monogon.dev/cloud/bmaas/bmdb/model",
visibility = ["//visibility:public"],
deps = [
Expand Down
2 changes: 1 addition & 1 deletion metropolis/vm/kube/apis/vm/v1alpha1/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ go_library(
embed = select({
"//metropolis/build/kube-code-generator:embed_deepcopy": [":go_kubernetes_library"],
"//conditions:default": [],
}),
}), # keep
importpath = "source.monogon.dev/metropolis/vm/kube/apis/vm/v1alpha1",
visibility = ["//visibility:public"],
deps = [
Expand Down

0 comments on commit 93ba807

Please sign in to comment.