Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency update needed imminently #110

Closed
fennelhans opened this issue May 9, 2023 · 3 comments · Fixed by #111
Closed

Dependency update needed imminently #110

fennelhans opened this issue May 9, 2023 · 3 comments · Fixed by #111
Assignees
@mono0926

Comments

@fennelhans
Copy link

Just a heads up that when the next version of Flutter drops (tomorrow), this package will start breaking.

The cause is due to the out-of-date dependency on macos_ui. I've submitted a bug report here:
macosui/macos_ui#423

Once that issue is resolved, you'll need to update to whatever version they cook up.
@github-project-automation github-project-automation bot moved this to Todo in mono OSS May 9, 2023
@mono0926 mono0926 self-assigned this May 10, 2023
@mono0926
Copy link
Owner

mono0926 commented May 10, 2023 •
edited
Loading

I'm considering to release 1.9.0-no-macos.0 or something which removes macos_ui dependency temporarily and show same UI as iOS instead 🤔

@mono0926 mono0926 mentioned this issue May 11, 2023
Merged
@mono0926 mono0926 linked a pull request May 11, 2023 that will close this issue
Fix Flutter 3.10 compile error caused by macos_ui package #111
Merged
mono0926 added a commit that referenced this issue May 11, 2023
@mono0926
Fix Flutter 3.10 compile error caused by macos_ui package (#111)
764f4e1 
Fix the issue as noted
#110 (comment)
@github-project-automation github-project-automation bot moved this from Todo to Done in mono OSS May 11, 2023
@mono0926 mono0926 mentioned this issue May 11, 2023
Closed
1 task
@mono0926
Copy link
Owner

@fennelhans

Thanks for the report 👍

Prerelease v1.9 is released and the issue is fixed:
https://pub.dev/packages/adaptive_dialog/versions/1.9.0-no-macos.2

@fennelhans
Copy link
Author

cant-thankyou-enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mono0926 mono0926

Labels
None yet
Projects
mono OSS
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Flutter 3.10 compile error caused by macos_ui package mono0926/adaptive_dialog
2 participants
@mono0926 @fennelhans