Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a memory leak in SKRoundRect #995

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Fix a memory leak in SKRoundRect #995

merged 2 commits into from
Nov 5, 2019

Conversation

mattleibow
Copy link
Contributor

Description of Change

Resolves a memory leak when the transformation fails, the allocated round rect that should have been deleted.

Bugs Fixed

API Changes

Added:

  • public bool SKRoundRect.TryTransform (SKMatrix matrix, out SKRoundRect transformed)

Behavioral Changes

None public. Just no longer leaks an instance.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow merged commit d529468 into master Nov 5, 2019
@mattleibow mattleibow deleted the dev/roundrect branch November 5, 2019 01:55
mattleibow added a commit that referenced this pull request Nov 6, 2019
Not quite sure what happened in #995
mattleibow added a commit that referenced this pull request Nov 6, 2019
Not quite sure what happened in #995
@mattleibow mattleibow added this to the v1.68.1 milestone Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Memory leak at SKRoundRect#Transform?
1 participant