Fix target files for Tizen to use TizenTPKFiles #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current temprary hacks for tizen-x86 RID are still needed because the Tizen 4.0 platform including .NETCore 2.0 does not understand the tizen-x86 RID. In this changes, Use TizenTPKFiles defined in Tizen.NET.Sdk instead of Link and CopyToOutputDirectory to solve following problems. - The linked file (runtime/linux-x86/native/foo.so) is displayed in VS Project tree. - The linked file is always copied to tpkroot/bin even when RID is specified. - The linked file can't be excluded using the file excluding features of Tizen.NET.Sdk.
|
|
|
/cc @vincent-kwon |
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
Thanks for this PR! I have merged it in and will be in the v1.60.3 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current temprary hacks for tizen-x86 RID are still needed because the Tizen 4.0 platform
including .NETCore 2.0 does not understand the tizen-x86 RID.
In this changes, Use TizenTPKFiles defined in Tizen.NET.Sdk instead of Link and CopyToOutputDirectory
to solve following problems.
The files added to TizenTPKFiles will be copied to tpkroot by Tizen.NET.Sdk, see
https://github.com/Samsung/build-task-tizen/blob/master/src/Tizen.NET.Build.Tasks/build/Tizen.NET.Sdk.Packaging.targets