Move the Blazor workaround into WASM #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workaround needed for WASM is not really Blazor specific and if the project is not using the Blazor views, the fix will not be applied to the build.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
The workaround needed for WASM is not really Blazor specific and if the project is not using the Blazor views, the fix will not be applied to the build. (cherry picked from commit 32fbf8d)
mattleibow
added a commit
that referenced
this pull request
Nov 27, 2024
The workaround needed for WASM is not really Blazor specific and if the project is not using the Blazor views, the fix will not be applied to the build. (cherry picked from commit 32fbf8d) Co-authored-by: Matthew Leibowitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The workaround needed for WASM is not really Blazor specific and if the project is not using the Blazor views, the fix will not be applied to the build.
The workaround for dotnet/runtime#109289 was added in #3064, however because a project may not be using the SkiaSharp.Views.Blazor package it will still fail.
Bugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist