Fix SKXamlCanvas on Uno Skia to use Bgra8888 #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
approved these changes
Jul 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
* Fix SKXamlCanvas on Uno Skia to use Bgra8888 * Fix build (cherry picked from commit c264c44)
mattleibow
pushed a commit
that referenced
this pull request
Jul 3, 2024
* Fix SKXamlCanvas on Uno Skia to use Bgra8888 * Fix build (cherry picked from commit c264c44) Co-authored-by: Youssef Victor <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Use Bgra8888 instead of PlatformColorType
Bugs Fixed
When not running on Windows where PlatformColorType may not be Bgra8888, rendering will be incorrect. In Uno, both WriteableBitmap and SkiaCompositionSurface deal explicitly with Bgra8888, so the format used in SKXamlCanvas has to match.
https://github.com/unoplatform/uno/blob/1d1f8c9f1f87fbb7e1af9d884049cef06cb46680/src/Uno.UI.Composition/Composition/SkiaCompositionSurface.skia.cs#L64
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist