Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps to Uno 4.0 #1873

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Bumps to Uno 4.0 #1873

merged 1 commit into from
Dec 17, 2021

Conversation

jeromelaban
Copy link
Contributor

Description of Change

This change bumps Uno to 4.0 preview bits, which include binary breaking changes.

Bugs Fixed

None

  • Related to issue #

API Changes

None

Behavioral Changes

Nonoe.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@jeromelaban
Copy link
Contributor Author

@mattleibow I assume the build errors are caused by the inclusion of nuget.org in the nuget.config file, though I'm not able to build locally as nuget.org packages are missing. What's the correct route to fix this ? Thanks!

@robloo
Copy link

robloo commented Dec 3, 2021

@jeromelaban @mattleibow This is an important issue as without it fixed Skia cannot be used with Uno Platform 4.x (UWP projects).

On my end attempting to construct an SKXamlCanvas with Skia preview version 2.88.0-preview.155 (SkiaSharp & SkiaSharp.Views.Uno) and Uno.UI version 4.0.8 throws the exception:

{System.TypeLoadException: Could not resolve type with token 0100007b from typeref (expected class 'Windows.UI.Core.UIAsyncOperation' in assembly 'Uno, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null')
at System.Runtime.CompilerServices.AsyncVoidMethodBuilder.Start[TStateMachine] (TStateMachine& stateMachine) [0x0002c] in /Users/builder/jenkins/workspace/archive-mono/2020-02/android/release/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/AsyncMethodBuilder.cs:84
at SkiaSharp.Views.UWP.SKXamlCanvas.Invalidate () [0x00007] in :0
at SkiaSharp.Views.UWP.SKXamlCanvas.OnDpiChanged (Windows.Graphics.Display.DisplayInformation sender, System.Object args) [0x00013] in D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno\SKXamlCanvas.cs:83
at SkiaSharp.Views.UWP.SKXamlCanvas.Initialize () [0x0000e] in D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno\SKXamlCanvas.cs:36
at SkiaSharp.Views.UWP.SKXamlCanvas..ctor () [0x00027] in D:\a\1\s\source\SkiaSharp.Views.Uno\SkiaSharp.Views.Uno.Android\SKXamlCanvas.Android.cs:14
at ...Controls.LineChart..ctor () [0x00177] in ...\Source\Controls\Charts\LineChart\LineChart.cs:108 }

@mikebmcl
Copy link

mikebmcl commented Dec 7, 2021

Is there any timeframe for this patch being applied and pushed to nuget? Possibly applied against 2.80.3 and published as a minor update of that if 2.88 isn't likely to be ready for release soon?

I've been tinkering with a replacement for my use of SkiaSharp and I'm almost at the point where I need to decide if I'm going to commit to that. Knowing the expected timeframe for this would help me greatly. Thanks!

mattleibow
mattleibow previously approved these changes Dec 14, 2021
@mattleibow mattleibow merged commit fffae82 into mono:main Dec 17, 2021
@robloo
Copy link

robloo commented Dec 21, 2021

This corresponds with the SkiaSharp 2.88.0-preview.179 nuget (including SkiaSharp.Views and SkiaSharp.Views.Uno)

Any Uno version < 4.0 must use SkiaSharp < 2.88.0-preview.179 and
Any Uno version >= 4.0 must use SkiaSharp >= 2.88.0-preview.179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants