Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Windows Symbols + HarfBuzzSharp.NativeAssets.* #1797

Merged
merged 13 commits into from
Sep 17, 2021

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Sep 6, 2021

Description of Change

  • Split the HarfBuzzSharp nuget into smaller NativeAssets variants
  • Add the native Windows pdb files to the symbol

Bugs Fixed

Using a local branch for 1792 so that we can build the samples and confirm all is good.

Info

Using *.symbols.nupkg as that seems to be the correct one for native/C++ symbols: https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg#nugetorg-symbol-package-constraints

(i) Note

Native projects, such as C++ projects, produce Windows PDBs instead of Portable PDBs. These are not supported by NuGet.org's symbol server. Please use Legacy Symbol Packages instead.

@mattleibow mattleibow merged commit 68e80fa into main Sep 17, 2021
@mattleibow mattleibow deleted the dev/native-symbols branch September 17, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Include libSkiaSharp.dll PDB files to the nuget package
2 participants