Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to publish Xamarin iOS app to App Store with SkiaSharp with 2.88.4 or 2.88.5 #2584

Closed
1 task done
eddieyanez opened this issue Aug 25, 2023 · 14 comments · Fixed by #2587
Closed
1 task done
Labels

Comments

@eddieyanez
Copy link

eddieyanez commented Aug 25, 2023

Description

The error I get when uploading the app to the Apple App Store is:

[Application Loader Error Output]: Asset validation failed Unsupported Architectures. The executable for AppNameXX.iOS.app/Frameworks/libSkiaSharp.framework contains unsupported architectures '[arm64e]'.

All works fine on version 2.88.3

Code

The best way to share code for larger projects is a link to a GitHub repository: https://github.com/user/repo/tree/bug-123

But, you can also share a short block of code here:

// some C# code here

You can also share some XAML:

<!-- xaml code here -->

Expected Behavior

No issues reported when uploading to the Apple App Store.

Actual Behavior

[Application Loader Error Output]: Asset validation failed Unsupported Architectures. The executable for AppNameXX.iOS.app/Frameworks/libSkiaSharp.framework contains unsupported architectures '[arm64e]'.

Version of SkiaSharp

Other (Please indicate in the description)

Last Known Good Version of SkiaSharp

Other (Please indicate in the description)

IDE / Editor

Visual Studio (macOS)

Platform / Operating System

iOS, macOS

Platform / Operating System Version

No response

Devices

No response

Relevant Screenshots

No response

Relevant Log Output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mattleibow
Copy link
Contributor

@rolfbjarne I have added the M1 simulator bits to the fat framework, but it appears that xamarin.ios is not stripping out the simulator arch?

Do I need a special something or is this a bug somewhere?

@rolfbjarne
Copy link
Member

@mattleibow you can't have a single .framework for both arm64 simulator and arm64 device. You need to use an .xcframework in that case (which contains two different .framework directories, one for the simulator and one for device).

@mattleibow
Copy link
Contributor

@rolfbjarne i looked again and I am not doing that... I have 2 frameworks, one for sim and one for device.

I have arm64 and arm64e in the device.

iphonesimulator: x86_64 + arm64
iphoneos: arm64 + arm64e

Is this correct, and do I still need to use an xcframework? I am a tiny bit hesitant as I will have to change the build a bit.

@rolfbjarne
Copy link
Member

@mattleibow no, you can just drop arm64e, Apple doesn't allow submissions with that architecture, it's of no use right now.

@mattleibow
Copy link
Contributor

Thanks!

mattleibow added a commit that referenced this issue Aug 28, 2023
mattleibow added a commit that referenced this issue Aug 28, 2023
github-actions bot pushed a commit that referenced this issue Aug 28, 2023
@mattleibow
Copy link
Contributor

I fixed this and will try push a preview with the fix soon.

mattleibow added a commit that referenced this issue Aug 29, 2023
Fixes #2584

(cherry picked from commit 4d5c011)

Co-authored-by: Matthew Leibowitz <[email protected]>
@zleao
Copy link

zleao commented Aug 30, 2023

Any idea when this will be published (even as a preview)?

@mattleibow
Copy link
Contributor

mattleibow commented Aug 30, 2023

Literally waiting on CI to finish the build and push :) Hopefully very soon. You can test right now using the preview feed:

If it works for you I can push out today. I am fairly confident, but you should be able to test that.

Are you abl to test and confirm easily, or does it require a full review by Apple?

@Ark667
Copy link

Ark667 commented Aug 31, 2023

Its working now, thank you!

@baneageorge
Copy link

I also had the same problem with v2.88.5. Strangely enough, when trying to upload from VS I was still getting an error. But the same archive I managed to upload with Transporter

@jimbowyer
Copy link

jimbowyer commented Sep 7, 2023

Thanks - this just unblocked us on iOS app store verification. v 2.88.5 was failing verification inside Xamarin Forms project with 'libSkiaSharp.framework contains unsupported architectures '[arm64e]''. Prerelease 2.88.6-preview.1.2 gets us past that and to a delivered app in submission review :)

@follesoe
Copy link

Excellent, thanks for the swift fix! Ran into the same issue, verifying using 2.88.6-preview.1.2 now.

@eddieyanez
Copy link
Author

Hi, I'm sorry I never saw this update. My email notifications were off, and so were on Github. Thanks for addressing the issue. I'll update to the latest version.

@mattleibow
Copy link
Contributor

There should be a new stable version filled with fixes! Enjoy!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants