Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SKImageSourceHandler not found in 1.68.1 for iOS project #1042

Closed
pmahend1 opened this issue Dec 2, 2019 · 8 comments · Fixed by #1044
Closed

[BUG] SKImageSourceHandler not found in 1.68.1 for iOS project #1042

pmahend1 opened this issue Dec 2, 2019 · 8 comments · Fixed by #1044
Milestone

Comments

@pmahend1
Copy link

pmahend1 commented Dec 2, 2019

Description
SKImageSourceHandler not found in 1.68.1 for iOS projecct

Code

Expected Behavior
Should be found

Actual Behavior
Compile error

Basic Information

  • Version with issue: 1.68.1
  • Last known good version: 1.68.0
  • IDE: Visual Studio / Visual Studio for Mac
  • Platform Target Frameworks: iOS
    • Android: NA
    • iOS: 13.2
    • Linux: NA
    • macOS: NA
    • Tizen: NA
    • tvOS: NA
    • UWP: NA
    • watchOS: NA
    • Windows Classic: NA
  • Target Devices: NA

Screenshots

image

Reproduction Link

SkiaImageSourceHandlerIssue

@pmahend1 pmahend1 changed the title [BUG] SKImageSourceHandler not found in 1.68.1 for iOS projecct [BUG] SKImageSourceHandler not found in 1.68.1 for iOS project Dec 2, 2019
@mattleibow
Copy link
Contributor

Just checking that you have installed the SkiaSharp.Views.Forms NuGet into the iOS project? That type should be in that package.

I can see it there: https://www.fuget.org/packages/SkiaSharp.Views.Forms/1.68.1/lib/xamarin.ios/SkiaSharp.Views.Forms.dll/SkiaSharp.Views.Forms/SKImageImageSource

@pmahend1
Copy link
Author

pmahend1 commented Dec 2, 2019

@pmahend1
Copy link
Author

pmahend1 commented Dec 2, 2019

@mattleibow is it because of this change in nuspec?

image

@mattleibow
Copy link
Contributor

It shouldn't be since iOS is .NET Standard 2.0 and the type should be in THAT nuget, not the dependencies.

Let me have a look at your repo.

mattleibow added a commit that referenced this issue Dec 2, 2019
All the assemblies are required to be in the ref folder as if there is any ref folder, it will take precedence over the lib folder. In the case where we have JUST the netstandard library in the ref, that is used for ALL platforms. Even though the correct assembly is swapped out at compile time, we actually have more things inside the assembly for the platforms.
@mattleibow
Copy link
Contributor

mattleibow commented Dec 2, 2019

I had a look and I see what is happening here. I moved the netstandard library into the ref folder in the nuget so that it won't actually run. But, it appears that the ref folder overrides ALL the platforms.

This typically is fine if the APIs are the same, but because we have more public types (such as SKImageSourceHandler) in the iOS (and the others) this doesn't work.

Fixing this in #1044 and I hope to push this out ASAP. I have a few fixes in there as well.

@mattleibow
Copy link
Contributor

@pmahend1 Thanks for reporting this issue. I have pushed out a fix to the preview feed:
https://aka.ms/skiasharp-eap/index.json

Try version 1.68.1.1-preview.2 as that should have the fix. (there is a 1.68.2 series, but that is actually older because I decided to get .1.1 out first with this fix)

@pmahend1
Copy link
Author

pmahend1 commented Dec 3, 2019

I checked ,it seem to have fixed the issue. @mattleibow Please let me know once you release into nuget org.

@mattleibow
Copy link
Contributor

Awesome. Will do.

@mattleibow mattleibow added this to the v1.68.1.1 milestone Dec 19, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants