Skip to content

Commit

Permalink
Use MacOS deployment target 10.8 as there seems to be a bug on 10.7 a…
Browse files Browse the repository at this point in the history
…nd certain versions of Xcode

See https://bugs.chromium.org/p/chromium/issues/detail?id=620127 for more information
  • Loading branch information
mattleibow committed Sep 4, 2016
1 parent 1585a22 commit 95ce2cb
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion build.cake
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ Task ("externals-osx")
.Does (() =>
{
var buildArch = new Action<string, string> ((arch, skiaArch) => {
RunGyp ("skia_arch_type='" + skiaArch + "' skia_gpu=1 skia_osx_deployment_target=10.7", "ninja,xcode");
RunGyp ("skia_arch_type='" + skiaArch + "' skia_gpu=1 skia_osx_deployment_target=10.8", "ninja,xcode");

XCodeBuild (new XCodeBuildSettings {
Project = "native-builds/libSkiaSharp_osx/libSkiaSharp.xcodeproj",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1637,7 +1637,7 @@
../../skia/include/utils,
../../skia/include/config,
);
MACOSX_DEPLOYMENT_TARGET = 10.7;
MACOSX_DEPLOYMENT_TARGET = 10.8;
OTHER_CPLUSPLUSFLAGS = (
"-std=c++0x",
"-stdlib=libc++",
Expand All @@ -1664,7 +1664,7 @@
../../skia/include/utils,
../../skia/include/config,
);
MACOSX_DEPLOYMENT_TARGET = 10.7;
MACOSX_DEPLOYMENT_TARGET = 10.8;
OTHER_CPLUSPLUSFLAGS = (
"-std=c++0x",
"-stdlib=libc++",
Expand Down
2 changes: 1 addition & 1 deletion samples/Skia.OSX.Demo/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<key>CFBundleVersion</key>
<string>1.0</string>
<key>LSMinimumSystemVersion</key>
<string>10.7</string>
<string>10.8</string>
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleInfoDictionaryVersion</key>
Expand Down
2 changes: 1 addition & 1 deletion samples/Skia.OSX.GLDemo/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<key>CFBundleVersion</key>
<string>1.0</string>
<key>LSMinimumSystemVersion</key>
<string>10.7</string>
<string>10.8</string>
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleInfoDictionaryVersion</key>
Expand Down

0 comments on commit 95ce2cb

Please sign in to comment.