Parsing errors even with release. #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dammit Ubuntu CI ***** up... |
HenrikVDestia
force-pushed
the
ParsingErrors
branch
2 times, most recently
from
1dfeb54 to
7de25de
Compare
|
There were spelling mistakes on the release config. |
Adds two macros to the CppParser/Parser.cpp for custom assert. They print out a message regardless is release or debug enabled. Abort is only called with debug. Macro `assertm` just prints out the message if the condition is false. Macro `assertml` also prints out the given source location to indicate where parsing fails. Macro `assertml` is not used often but might be good to be used more. Also, I removed an assert that seems pointless as if check before it handles it already.
HenrikVDestia
force-pushed
the
ParsingErrors
branch
from
7de25de to
b4eae99
Compare
|
Ubuntu had problems with |
HenrikVDestia
force-pushed
the
ParsingErrors
branch
2 times, most recently
from
31ebc7c to
b4eae99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two macros to the CppParser/Parser.cpp for custom assert. They print out a message regardless is release or debug enabled. Abort is only called with debug.
Macro
assertmjust prints out the message if the condition is false. Macroassertmlalso prints out the given source location to indicate where parsing fails.Macro
assertmlis not used often but might be good to be used more.Also, I removed an assert that seems pointless as if check before it handles it already.