Skip to content

Commit

Permalink
Add var port polling in host phase to flush out any pending reads (la…
Browse files Browse the repository at this point in the history
…va-nc#563)

* Add var port polling in host phase to flush out any pending reads

* Added unit test
  • Loading branch information
joyeshmishra authored Jan 9, 2023
1 parent cf4b626 commit d3e9774
Show file tree
Hide file tree
Showing 2 changed files with 67 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/lava/magma/core/model/py/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,8 @@ def add_ports_for_polling(self):
Add various ports to poll for communication on ports
"""
if enum_equal(self.phase, PyLoihiProcessModel.Phase.PRE_MGMT) or \
enum_equal(self.phase, PyLoihiProcessModel.Phase.POST_MGMT):
enum_equal(self.phase, PyLoihiProcessModel.Phase.POST_MGMT) \
or enum_equal(self.phase, PyLoihiProcessModel.Phase.HOST):
for var_port in self.var_ports:
for csp_port in var_port.csp_ports:
if isinstance(csp_port, CspRecvPort):
Expand Down
67 changes: 65 additions & 2 deletions tests/lava/magma/runtime/test_ref_var_ports.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
import numpy as np
import unittest

from lava.magma.core.decorator import implements, requires
from lava.magma.core.decorator import implements, requires, tag
from lava.magma.core.model.py.model import PyLoihiProcessModel
from lava.magma.core.model.py.ports import PyRefPort, PyVarPort
from lava.magma.core.model.py.ports import PyRefPort, PyVarPort, PyInPort
from lava.magma.core.model.py.type import LavaPyType
from lava.magma.core.model.sub.model import AbstractSubProcessModel
from lava.magma.core.process.ports.ports import RefPort, VarPort
Expand Down Expand Up @@ -319,5 +319,68 @@ def test_hierarchical_ref_ports(self):
recv.stop()


class TestPortsInProcess(unittest.TestCase):
"""Tests PyPorts in Processes."""

def test_refport_write_to_varport(self) -> None:
"""Tests writing from a RefPort to a VarPort."""
num_steps = 1
shape = (4, 3, 2)
np.random.seed(7739)
input_data = np.random.randint(256, size=shape)

source = RefPortWriteProcess(data=input_data)
sink = VarPortProcess(data=np.zeros(shape))

source.ref_port.connect(sink.var_port)

try:
sink.run(condition=RunSteps(num_steps=num_steps),
run_cfg=Loihi1SimCfg(select_tag='floating_pt'))
output = sink.data.get()
finally:
sink.stop()

np.testing.assert_array_equal(output, input_data)


class RefPortWriteProcess(AbstractProcess):
def __init__(self, data: np.ndarray) -> None:
super().__init__()
self.data = Var(shape=data.shape, init=data)
self.ref_port = RefPort(shape=data.shape)


class VarPortProcess(AbstractProcess):
def __init__(self, data: np.ndarray) -> None:
super().__init__()
self.data = Var(shape=data.shape, init=data)
self.var_port = VarPort(self.data)


@implements(proc=RefPortWriteProcess, protocol=LoihiProtocol)
@requires(CPU)
@tag('floating_pt')
class PyRefPortWriteProcessModelFloat(PyLoihiProcessModel):
ref_port: PyRefPort = LavaPyType(PyRefPort.VEC_DENSE, np.int32)
data: np.ndarray = LavaPyType(np.ndarray, np.int32)

def post_guard(self):
return True

def run_post_mgmt(self):
self.ref_port.write(self.data)
self.log.info("Sent output data of RefPortWriteProcess: ",
str(self.data))


@implements(proc=VarPortProcess, protocol=LoihiProtocol)
@requires(CPU)
@tag('floating_pt')
class PyVarPortProcessModelFloat(PyLoihiProcessModel):
var_port: PyInPort = LavaPyType(PyVarPort.VEC_DENSE, np.int32)
data: np.ndarray = LavaPyType(np.ndarray, np.int32)


if __name__ == '__main__':
unittest.main()

0 comments on commit d3e9774

Please sign in to comment.