-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-3463]: Added commands to add/remove the current theme to favorites #3682
[GH-3463]: Added commands to add/remove the current theme to favorites #3682
Conversation
As the name suggests the command should add the theme to favorites, not toggle it. Please fix that. |
Also the code you have written doesn't take into account the fact that the user could have custom themes activated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the problems mentioned.
@rizwanmustafa @varunKT001 I DO want the command to also remove from favorites. (but please update the text to "remove theme from favorites" if its already a favorite) |
Update: Instead of updating the same command, add a second command (to remove from favorites) and then just toggle the visibility of them based on if the theme is favorite or not |
Done 👍
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge add and remove commands into one file
Done 👍 |
Thanks |
I'm glad to contribute to one of my favorite applications I use daily 😄 |
Description
I added the 'Add current theme to favorite...' command. If the theme is already present in the favorite list, we'll remove it from the list. Otherwise, we'll add it to the favorites list.
Screenshots
Closes #3463