Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-3463]: Added commands to add/remove the current theme to favorites #3682

Merged
merged 7 commits into from
Oct 25, 2022

Conversation

varunKT001
Copy link
Contributor

Description

I added the 'Add current theme to favorite...' command. If the theme is already present in the favorite list, we'll remove it from the list. Otherwise, we'll add it to the favorites list.

Screenshots

image
image

Closes #3463

@github-actions github-actions bot added the frontend User interface or web stuff label Oct 25, 2022
@rizwanmustafa
Copy link
Member

As the name suggests the command should add the theme to favorites, not toggle it. Please fix that.

@rizwanmustafa
Copy link
Member

Also the code you have written doesn't take into account the fact that the user could have custom themes activated.

Copy link
Member

@rizwanmustafa rizwanmustafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the problems mentioned.

@Miodec
Copy link
Member

Miodec commented Oct 25, 2022

@rizwanmustafa @varunKT001 I DO want the command to also remove from favorites. (but please update the text to "remove theme from favorites" if its already a favorite)

@Miodec
Copy link
Member

Miodec commented Oct 25, 2022

Update: Instead of updating the same command, add a second command (to remove from favorites) and then just toggle the visibility of them based on if the theme is favorite or not

@varunKT001
Copy link
Contributor Author

@Miodec @rizwanmustafa

I DO want the command to also remove from favorites.

Done 👍

Update: Instead of updating the same command, add a second command (to remove from favorites) and then just toggle the visibility of them based on if the theme is favorite or not

Done 👍

@varunKT001 varunKT001 changed the title Added 'Add current theme to favorite...' command Added commands to add/remove the current theme to favorites Oct 25, 2022
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge add and remove commands into one file

@varunKT001
Copy link
Contributor Author

Please merge add and remove commands into one file

Done 👍

@Miodec Miodec merged commit 1afca82 into monkeytypegame:master Oct 25, 2022
@Miodec
Copy link
Member

Miodec commented Oct 25, 2022

Thanks

@varunKT001
Copy link
Contributor Author

I'm glad to contribute to one of my favorite applications I use daily 😄

@Miodec Miodec added hacktoberfest-accepted Hacktoberfest stuff and removed hacktoberfest-accepted Hacktoberfest stuff labels Oct 25, 2022
@varunKT001 varunKT001 changed the title Added commands to add/remove the current theme to favorites [GH-3463]: Added commands to add/remove the current theme to favorites Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "add current theme to favorite" command
3 participants