Cgroup parent #100
Merged
Cgroup parent #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Which Kubernetes version has been used for your testing? |
|
Tested using Kubernetes version:1.8.3. |
|
Cc: @baoh0308 - version with |
jangaraj
reviewed
Jul 29, 2018
| @@ -738,10 +817,19 @@ int zbx_docker_dir_detect() | |||
| { | |||
| if ((strstr(path, "cpuset cgroup")) != NULL) | |||
| { | |||
|
|
|||
| #ifdef ZBX_VERSION_PRE_3_0_17 | |||
There was a problem hiding this comment.
Where and how do you define ZBX_VERSION_PRE_3_0_17?
There was a problem hiding this comment.
I defined the marco when building with gcc using -D. The built module supported version depends on the compile options.
|
I'm merging this one into the feature branch. TODO:
Tested:
I'll be happy to receive any (un)sucessfull reports for other orchestratation tools (maybe @baoh0308 will be able to test it as well). Anyway, thank you @miaofenk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jangaraj ,
I did a few code changes to make the cgroup parent branch supports containers under K8S environment. Would you please review my code changes and decide whether to take the pull request?
Thanks for your time!