Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily fix Bootstrap tabs (#26) #200

Merged
merged 1 commit into from
Jun 11, 2017
Merged

Temporarily fix Bootstrap tabs (#26) #200

merged 1 commit into from
Jun 11, 2017

Conversation

BranTurner
Copy link

@BranTurner BranTurner commented Jun 11, 2017

Provides a temporary fix for #26. The problem has been fixed in the Bootstrap v4-dev branch but has not yet been released - hopefully won't be too long.

Summary:

  • Added a 'scripts' stack to the layout file, so that the javascript fix doesn't have to be present on all pages
  • Added a temporary javascript fix to manually add/remove the "active" class from the tabs when clicked

@djaiss
Copy link
Member

djaiss commented Jun 11, 2017

Thank so much for caring about the project and for this pull request.
The PR looks awesome, I'll merge it right away.

@djaiss djaiss merged commit e5ebc21 into monicahq:master Jun 11, 2017
@BranTurner
Copy link
Author

I'll try to remember to remove this when Bootstrap is out of beta! Thanks for the merge.

@BranTurner BranTurner deleted the bug-fix-dashboard-tabs branch June 12, 2017 15:53
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants