Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tests to molecule 2.x #49

Merged
merged 7 commits into from
May 12, 2018
Merged

Conversation

paulfantom
Copy link
Collaborator

@paulfantom paulfantom changed the title WIP: move tests to molecule 2.x move tests to molecule 2.x May 7, 2018
@paulfantom paulfantom requested a review from mongrelion May 7, 2018 20:38
Copy link
Owner

@mongrelion mongrelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good.
The only thing I have to add is that it's a good practice to not include in your code changes code that has been commented out. If it's not needed, better not to add it to the repo at all.

@paulfantom
Copy link
Collaborator Author

Those commented changes are for future support of more distros. I included those because they where included in molecule 1.x.

@paulfantom paulfantom merged commit 0bca358 into mongrelion:master May 12, 2018
@paulfantom paulfantom deleted the molecule2 branch May 12, 2018 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants