Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add support for ordered_by matcher for Mongoid 5 and older #221

Conversation

stim371
Copy link
Contributor

@stim371 stim371 commented Jul 30, 2018

The PR to support Mongoid 6 removed a conditional to select the correct
location for the Key class.

Fixes #214

Question for Maintainer

This PR fails a rubocop check for Class length. Curious if you'd like to try to golf the class or extend/ignore the rubocop check.

@stim371 stim371 force-pushed the support-ordered_by-mongo-5-and-less branch 2 times, most recently from f4d1179 to f5d2a2f Compare July 30, 2018 20:20
@dblock
Copy link
Collaborator

dblock commented Jul 31, 2018

For rubocop just run rubocop -a ; rubocop --auto-gen-config, we only care about auto-correctable things.

@dblock
Copy link
Collaborator

dblock commented Jul 31, 2018

Thanks for fixing this, will merge on green.

The PR to support Mongoid 6 removed a conditional to select the correct
location for the Key class.

Fixes mongoid#214
@stim371 stim371 force-pushed the support-ordered_by-mongo-5-and-less branch from f5d2a2f to a9c6ac7 Compare August 1, 2018 00:35
@stim371
Copy link
Contributor Author

stim371 commented Aug 1, 2018

Thanks, @dblock . Should be all set!

@dblock dblock merged commit b54d300 into mongoid:master Aug 1, 2018
@zedtux
Copy link

zedtux commented Aug 8, 2018

Thank you @stim371 ! 🎉

@zedtux
Copy link

zedtux commented Aug 8, 2018

@dblock will you release a new version of this gem soon?

@dblock
Copy link
Collaborator

dblock commented Aug 8, 2018

I can, but this gem really could use some more maintainers. Maybe @stim371 wants to join? If yes what's your rubygems email, I'll grant you access.

@stim371
Copy link
Contributor Author

stim371 commented Aug 15, 2018

@dblock I see a number of open issues that might be interesting to try to pick off, but I'm about to move away from mongoid (switching orgs), so I don't think I'd be a very active/invested maintainer for the long term.

@zedtux
Copy link

zedtux commented Aug 16, 2018

Lucky you are @stim371 😏

@dblock
Copy link
Collaborator

dblock commented Aug 16, 2018

Thanks @stim371, no worries. Definitely looking forward to you contributions time permitting! Also MongoDB is great, I don't know what ya'll talking about :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants