Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-503: Configurable cluster timeouts #951

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Conversation

evertsd
Copy link
Contributor

@evertsd evertsd commented Dec 2, 2022

Description

Some cluster cases take well over 3 hours for changes to apply, this empowers people to set timeouts that work for them.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@evertsd evertsd requested a review from a team as a code owner December 2, 2022 15:31
@evertsd evertsd changed the title INTMDB-503: Configurable cluster timeouts Draft: INTMDB-503: Configurable cluster timeouts Dec 2, 2022
@evertsd
Copy link
Contributor Author

evertsd commented Dec 2, 2022

I have not actually had a chance to test this yet, though believe this is all the code that's needed and thought there was some merit to pushing up the code & opening this as a WIP

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zuhairahmed
Copy link
Collaborator

Thanks @evertsd, can we also update Registry Docs (for both Adv Cluster + Cluster) to call out that timeouts are now customizable so customers know to leverage?

@Zuhairahmed Zuhairahmed self-requested a review December 2, 2022 17:51
@evertsd evertsd changed the title Draft: INTMDB-503: Configurable cluster timeouts INTMDB-503: Configurable cluster timeouts Dec 5, 2022
@evertsd
Copy link
Contributor Author

evertsd commented Dec 5, 2022

Ok @Zuhairahmed that documentation has been added

Copy link
Collaborator

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @evertsd, LGTM!

@evertsd evertsd merged commit 7b73d34 into master Dec 5, 2022
@martinstibbe martinstibbe deleted the v1.6.1_INTMDB-503 branch January 4, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants