Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(resource/role_mapping): add link to reference of available role IDs #919

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

Horgix
Copy link
Contributor

@Horgix Horgix commented Nov 14, 2022

Description

When creating mongodbatlas_federated_settings_org_role_mapping resources, one might wonder what are the available identifiers for the roles field. This adds a link to their reference.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

No relevant test to add.

Further comments

None.

When creating `mongodbatlas_federated_settings_org_role_mapping`
resources, one might wonder what are the available identifiers for the
`roles` field. This adds a link to their reference.
@Horgix Horgix requested a review from a team as a code owner November 14, 2022 14:45
@Zuhairahmed Zuhairahmed self-requested a review November 14, 2022 15:02
Copy link
Collaborator

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great add, thank you @Horgix! LGTM

@Zuhairahmed Zuhairahmed merged commit 818af5d into mongodb:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants