Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release staging v1.5.0 #887

Merged
merged 14 commits into from
Nov 2, 2022
Merged

Release staging v1.5.0 #887

merged 14 commits into from
Nov 2, 2022

Conversation

evertsd
Copy link
Contributor

@evertsd evertsd commented Oct 27, 2022

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

martinstibbe and others added 4 commits October 20, 2022 10:58
* Update CHANGELOG.md (#849)

* INTMDB-405: Add default label if none supplied

* Add test for default label exising

* Flatten nested IF statement
* Made timeout for privatelink endpoint service configurable

* Updated context to be with timeout, added documentation on how the timeout works

* Updated documentation to have proper default timeout of 2h
…_config resource (#877)

* Add support for MS Teams SDK webhook

* make fmt

* Update documentation add Webhook

* Update docs

* Update to v0.18
Zuhairahmed and others added 2 commits October 26, 2022 22:09
* Add Gov variables workflow and test case

* Change test pre check to handle gov env variables

* Adjust env variable test validation

* Add provider parameter for Gov cloud and region_usage_restrictions to datasources

* Update project government test update docs
@themantissa themantissa requested review from a team and removed request for andreaangiolillo October 29, 2022 00:14
* INTMDB-369: Updated validation logic for cloud_backup_snapshot_restore_job (#813)

* Updated validation logic for cloud_backup_snapshot_restore_job

* Fixed lint errors

* Updated test-upgrade v110 to use pit restore

* Fixed var name in example for pit ts

* Updated v110 example to use cloud backup snapshot resource with pit and valid instructions

* Removed changes to v110 example and created a v146 example

* Fixed the v110 example to work with disk_size requirements and added link to new examples on the tf docs.

* Fixed documentation and moved example

* Moved example again, and fixed links in documentation

* Fixed formatting on example

* Fixed formatting to account for removal of disk size
@martinstibbe martinstibbe added the not_stale Not stale issue or PR label Oct 31, 2022
martinstibbe and others added 7 commits November 1, 2022 08:30
* Add link for How To Guide for existing container ID

* Document corrections

* 3 remaining doc updates
* Initial commit for cluster upgrade

* Updated to use a custom customizeDiff func

* Setting cluster_id and resource ID to the updated values in the case of a cluster upgrade

* Updated logic for determining whether upgrade is required

* Removed conflation on willUpgrade and tenant changes. Added error checking

* Updated cluster docs to denote upgrade support

* Added an example tenant upgrade

* Fixed formatting issues

* Added code to upgrade advanced_cluster

* Moved example again, for some reason

* Moved examples, got advanced-cluster tenantUpgrade working

* Fixed linter issues with advanced cluster

* removed unnecessary explicit setting of cluster_id

* Updated new examples to work with tf 0.13

* Update website/docs/r/advanced_cluster.html.markdown

Co-authored-by: Melissa Plunkett <[email protected]>

* Update website/docs/r/advanced_cluster.html.markdown

Co-authored-by: Melissa Plunkett <[email protected]>

* Update website/docs/r/advanced_cluster.html.markdown

Co-authored-by: Melissa Plunkett <[email protected]>

* Update website/docs/r/cluster.html.markdown

Co-authored-by: Melissa Plunkett <[email protected]>

* Addressed some criticisms of new tenant-upgrade examples

* Applied suggested docs changes for cluster tenant upgrade

* Apply suggestions from code review

Applied docs changes suggested for advanced-cluster tenant upgrade readme

Co-authored-by: Melissa Plunkett <[email protected]>

* Updated cluster tenant upgrade readme to match that of the advanced cluster

* Addressed last remaining README suggestions for new examples

* Fixed naming on variables and re-pausing cluster after upgrade if necessary

* Reduced nested ifs in cluster update

* No longer attempting to unpause tenant tier clusters prior to upgrade. Any updates fail

* Fixed linter error on bool init

Co-authored-by: Melissa Plunkett <[email protected]>
@martinstibbe martinstibbe changed the title WIP: Release staging v1.5.0 Release staging v1.5.0 Nov 2, 2022
@Zuhairahmed Zuhairahmed self-requested a review November 2, 2022 18:45
Copy link
Collaborator

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but for next stage few suggestions for CHANGELOG.md:

  1. Split up v1.5 updates (and going forward) into: ENHANCEMENTS, BUG FIXES, and OTHER (can include Dependabot updates and other items that don't fit cleanly in first two buckets). This will model ours off HashiCorp Terraform CHANGELOG
  2. Let's call out INTMDB-349 as additional changelog update so users know of new parameter for Atlas Gov

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinstibbe martinstibbe merged commit cc13817 into master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not_stale Not stale issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants