Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix custom_dns_configuration_cluster_aws #860

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

tooooots
Copy link
Contributor

@tooooots tooooots commented Oct 4, 2022

Description

The import of this resource should performed using the project ID, not the auditing ID. I think the reference to the "Auditing ID" is a typo and I've been able to import this resource using the project ID (Group ID).

References:
https://www.mongodb.com/docs/atlas/reference/api/aws-custom-dns-get/
https://registry.terraform.io/providers/mongodb/mongodbatlas/latest/docs/resources/custom_dns_configuration_cluster_aws

Link to any related issue(s):
N/A

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

The import of this resource should performed using the project ID, not the auditing ID.
@tooooots tooooots requested a review from themantissa as a code owner October 4, 2022 13:50
@Zuhairahmed Zuhairahmed self-requested a review October 19, 2022 22:43
@themantissa
Copy link
Collaborator

@tooooots thank you for the submission and for signing the CLA. Are you sure the import was successful? Can you see the resource in your state? I ask because checking the code: https://github.com/mongodb/terraform-provider-mongodbatlas/blob/master/mongodbatlas/resource_mongodbatlas_custom_dns_configuration_cluster_aws.go I don't actually see an import function.

@tooooots
Copy link
Contributor Author

tooooots commented Nov 3, 2022

I just tested using provider 1.4.6 and it gets imported into the statefile:

 {
  "version": 4,
  "terraform_version": "1.1.9",
  "serial": 1,
  "lineage": "redacted",
  "outputs": {},
  "resources": [
    {
      "mode": "managed",
      "type": "mongodbatlas_custom_dns_configuration_cluster_aws",
      "name": "default",
      "provider": "provider[\"registry.terraform.io/mongodb/mongodbatlas\"]",
      "instances": [
        {
          "schema_version": 0,
          "attributes": {
            "enabled": false,
            "id": "redacted",
            "project_id": "redacted"
          },
          "sensitive_attributes": [],
          "private": "redacted"
        }
      ]
    }
  ]
}

@Zuhairahmed Zuhairahmed added the not_stale Not stale issue or PR label Nov 3, 2022
@Zuhairahmed Zuhairahmed requested a review from a team as a code owner November 3, 2022 17:13
Copy link
Collaborator

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added another commit updating link to our latest OpenAPI Documentation (which also highlights that Project ID is a required field for this endpoint). @martinstibbe can you double check this as well?

@gssbzn
Copy link
Collaborator

gssbzn commented Nov 4, 2022

LGTM I also verified the CLA is signed

@Zuhairahmed
Copy link
Collaborator

Thanks @gssbzn! appreciate the double check here

@Zuhairahmed Zuhairahmed merged commit a2905f3 into mongodb:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not_stale Not stale issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants