Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-331 - Update GCP documentation #793

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

evertsd
Copy link
Contributor

@evertsd evertsd commented Jul 25, 2022

Description

Updated documentation and examples to inform usage of gcp forwarding rules with the mongodbatlas_privatelink_endpoint_service resource

Addresses issue 753

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@evertsd evertsd requested a review from themantissa as a code owner July 25, 2022 13:23
@Zuhairahmed Zuhairahmed self-requested a review July 26, 2022 14:48
Copy link
Contributor

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix updates both documentation as well as default variable names in .tf files. User signed CLA.

@evertsd evertsd changed the base branch from master to release-staging-v1.4.4 July 26, 2022 21:21
@themantissa themantissa requested review from a team and martinstibbe July 26, 2022 23:16
@themantissa
Copy link
Collaborator

@martinstibbe since you worked on this in the HELP ticket would you mind doing a quick review?

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad to have these corrected!

Copy link
Contributor

@martinstibbe martinstibbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themantissa themantissa requested review from a team and removed request for a team July 28, 2022 19:35
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinstibbe martinstibbe merged commit bfc365e into release-staging-v1.4.4 Aug 2, 2022
@martinstibbe martinstibbe deleted the INTMDB-331 branch August 2, 2022 04:44
martinstibbe added a commit that referenced this pull request Aug 16, 2022
* INTMDB-343: Update go from 1.16 to 1.17 add windows arm64 build support (#797)

* INTMDB-343: Update go from 1.16 to 1.17 add windows arm64 build support

* feat: Update to use go1.17

* actually update

Co-authored-by: Gustavo Bazan <[email protected]>

* Setting name on project data_source read (#795)

* INTMDB-331 - Update GCP documentation (#793)

* Updated gcp compute address & forwarding rule examples

* Fixed formatting

* Commenting out credentials for fmting purposes

* Updated import documentation for global_cluster_config (#796)

* INTMDB-355: [Terraform] Customer HELP ticket - hitting panic when trying to set maintenance windows (#800)

* INTMDB-362: Header Clarifications "Resource" vs "Data Source" in Documentation   (#803)

* Update CONTRIBUTING.md (#798)

Clarify use of release branch

* INTMDB-362

Header Clarifications "Resource" vs "Data Source" to be more in line with other providers as well to make easier for user. Documentation update only.

* Revert "Update CONTRIBUTING.md (#798)"

This reverts commit 71b9173.

* Revert "Revert "Update CONTRIBUTING.md (#798)""

This reverts commit 147159c.

Co-authored-by: Melissa Plunkett <[email protected]>

* INTMDB-357: Add exclude to skip go-header until google terraform provider version tag upgrade (#799)

* INTMDB-357: Add exclude to skip go-header until google terraform provider version tag upgrade

* Ran go mod tidy -compat=1.17

* Fix test to use aws provider ctedentials (#807)

* Update CHANGELOG.md

* go mod tidy

* Go lang lint update to v1.41.2

* GOLANGCI_VERSION=v1.42.1

* Try latest

* Fix go.sum

* golangci version

* tidy

* fixes

* fixes

* Update resource_mongodbatlas_database_user_test.go

Co-authored-by: Gustavo Bazan <[email protected]>
Co-authored-by: Dosty Everts <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Melissa Plunkett <[email protected]>
guineveresaenger pushed a commit to pulumi/terraform-provider-mongodbatlas that referenced this pull request Sep 13, 2022
* INTMDB-343: Update go from 1.16 to 1.17 add windows arm64 build support (mongodb#797)

* INTMDB-343: Update go from 1.16 to 1.17 add windows arm64 build support

* feat: Update to use go1.17

* actually update

Co-authored-by: Gustavo Bazan <[email protected]>

* Setting name on project data_source read (mongodb#795)

* INTMDB-331 - Update GCP documentation (mongodb#793)

* Updated gcp compute address & forwarding rule examples

* Fixed formatting

* Commenting out credentials for fmting purposes

* Updated import documentation for global_cluster_config (mongodb#796)

* INTMDB-355: [Terraform] Customer HELP ticket - hitting panic when trying to set maintenance windows (mongodb#800)

* INTMDB-362: Header Clarifications "Resource" vs "Data Source" in Documentation   (mongodb#803)

* Update CONTRIBUTING.md (mongodb#798)

Clarify use of release branch

* INTMDB-362

Header Clarifications "Resource" vs "Data Source" to be more in line with other providers as well to make easier for user. Documentation update only.

* Revert "Update CONTRIBUTING.md (mongodb#798)"

This reverts commit 71b9173.

* Revert "Revert "Update CONTRIBUTING.md (mongodb#798)""

This reverts commit 147159c.

Co-authored-by: Melissa Plunkett <[email protected]>

* INTMDB-357: Add exclude to skip go-header until google terraform provider version tag upgrade (mongodb#799)

* INTMDB-357: Add exclude to skip go-header until google terraform provider version tag upgrade

* Ran go mod tidy -compat=1.17

* Fix test to use aws provider ctedentials (mongodb#807)

* Update CHANGELOG.md

* go mod tidy

* Go lang lint update to v1.41.2

* GOLANGCI_VERSION=v1.42.1

* Try latest

* Fix go.sum

* golangci version

* tidy

* fixes

* fixes

* Update resource_mongodbatlas_database_user_test.go

Co-authored-by: Gustavo Bazan <[email protected]>
Co-authored-by: Dosty Everts <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Melissa Plunkett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants