-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTMDB-331 - Update GCP documentation #793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix updates both documentation as well as default variable names in .tf files. User signed CLA.
@martinstibbe since you worked on this in the HELP ticket would you mind doing a quick review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, glad to have these corrected!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* INTMDB-343: Update go from 1.16 to 1.17 add windows arm64 build support (#797) * INTMDB-343: Update go from 1.16 to 1.17 add windows arm64 build support * feat: Update to use go1.17 * actually update Co-authored-by: Gustavo Bazan <[email protected]> * Setting name on project data_source read (#795) * INTMDB-331 - Update GCP documentation (#793) * Updated gcp compute address & forwarding rule examples * Fixed formatting * Commenting out credentials for fmting purposes * Updated import documentation for global_cluster_config (#796) * INTMDB-355: [Terraform] Customer HELP ticket - hitting panic when trying to set maintenance windows (#800) * INTMDB-362: Header Clarifications "Resource" vs "Data Source" in Documentation (#803) * Update CONTRIBUTING.md (#798) Clarify use of release branch * INTMDB-362 Header Clarifications "Resource" vs "Data Source" to be more in line with other providers as well to make easier for user. Documentation update only. * Revert "Update CONTRIBUTING.md (#798)" This reverts commit 71b9173. * Revert "Revert "Update CONTRIBUTING.md (#798)"" This reverts commit 147159c. Co-authored-by: Melissa Plunkett <[email protected]> * INTMDB-357: Add exclude to skip go-header until google terraform provider version tag upgrade (#799) * INTMDB-357: Add exclude to skip go-header until google terraform provider version tag upgrade * Ran go mod tidy -compat=1.17 * Fix test to use aws provider ctedentials (#807) * Update CHANGELOG.md * go mod tidy * Go lang lint update to v1.41.2 * GOLANGCI_VERSION=v1.42.1 * Try latest * Fix go.sum * golangci version * tidy * fixes * fixes * Update resource_mongodbatlas_database_user_test.go Co-authored-by: Gustavo Bazan <[email protected]> Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]> Co-authored-by: Melissa Plunkett <[email protected]>
* INTMDB-343: Update go from 1.16 to 1.17 add windows arm64 build support (mongodb#797) * INTMDB-343: Update go from 1.16 to 1.17 add windows arm64 build support * feat: Update to use go1.17 * actually update Co-authored-by: Gustavo Bazan <[email protected]> * Setting name on project data_source read (mongodb#795) * INTMDB-331 - Update GCP documentation (mongodb#793) * Updated gcp compute address & forwarding rule examples * Fixed formatting * Commenting out credentials for fmting purposes * Updated import documentation for global_cluster_config (mongodb#796) * INTMDB-355: [Terraform] Customer HELP ticket - hitting panic when trying to set maintenance windows (mongodb#800) * INTMDB-362: Header Clarifications "Resource" vs "Data Source" in Documentation (mongodb#803) * Update CONTRIBUTING.md (mongodb#798) Clarify use of release branch * INTMDB-362 Header Clarifications "Resource" vs "Data Source" to be more in line with other providers as well to make easier for user. Documentation update only. * Revert "Update CONTRIBUTING.md (mongodb#798)" This reverts commit 71b9173. * Revert "Revert "Update CONTRIBUTING.md (mongodb#798)"" This reverts commit 147159c. Co-authored-by: Melissa Plunkett <[email protected]> * INTMDB-357: Add exclude to skip go-header until google terraform provider version tag upgrade (mongodb#799) * INTMDB-357: Add exclude to skip go-header until google terraform provider version tag upgrade * Ran go mod tidy -compat=1.17 * Fix test to use aws provider ctedentials (mongodb#807) * Update CHANGELOG.md * go mod tidy * Go lang lint update to v1.41.2 * GOLANGCI_VERSION=v1.42.1 * Try latest * Fix go.sum * golangci version * tidy * fixes * fixes * Update resource_mongodbatlas_database_user_test.go Co-authored-by: Gustavo Bazan <[email protected]> Co-authored-by: Dosty Everts <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]> Co-authored-by: Melissa Plunkett <[email protected]>
Description
Updated documentation and examples to inform usage of gcp forwarding rules with the mongodbatlas_privatelink_endpoint_service resource
Addresses issue 753
Type of change:
Required Checklist:
Further comments