INTMDB-295: Fixes a bug about unauthorized error in project resource #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderGo93
requested review from
abner-dou and
andreaangiolillo
as code owners
Comment on lines
143
to
147
| var target *matlas.ErrorResponse | ||
| if errors.As(err, &target) && target.ErrorCode != "USER_UNAUTHORIZED" { | ||
| return diag.Errorf("error getting project's api keys (%s): %s", projectID, err) | ||
| } | ||
| } |
There was a problem hiding this comment.
based on this change, apiKeys will still be empty when the request getProjectAPIKeys returns the error USER_UNAUTHORIZED so I would print a warning explaining why this field is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to any related issue(s):
#659
Type of change:
Required Checklist:
Further comments