Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-287: Fixes the issues in project api keys #639

Merged
merged 9 commits into from
Dec 17, 2021
Merged

INTMDB-287: Fixes the issues in project api keys #639

merged 9 commits into from
Dec 17, 2021

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Dec 15, 2021 •
edited
Loading

Description

  • Added validation to get the roles of a project id instead of all of not related to project id
  • Added env var for api keys in workflow yaml
  • Changed fatal to skip to avoid crashing in automated test

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Dec 15, 2021
gssbzn
gssbzn approved these changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thetonymaster
thetonymaster approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@thetonymaster thetonymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

themantissa
themantissa approved these changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coderGo93 coderGo93 added the run-testacc To run acceptance tests label Dec 15, 2021
@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Dec 16, 2021
@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Dec 16, 2021
@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Dec 16, 2021
@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Dec 16, 2021
@coderGo93 coderGo93 merged commit 8ace782 into master Dec 17, 2021
@coderGo93 coderGo93 deleted the INTMDB-287 branch December 17, 2021 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetonymaster thetonymaster thetonymaster approved these changes

@themantissa themantissa themantissa approved these changes

@gssbzn gssbzn gssbzn approved these changes

@abner-dou abner-dou Awaiting requested review from abner-dou

@andreaangiolillo andreaangiolillo Awaiting requested review from andreaangiolillo

Assignees

@coderGo93 coderGo93

Labels
run-testacc To run acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coderGo93 @gssbzn @themantissa @thetonymaster