Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tag version 1.0.1 for pre release #546

Merged
merged 2 commits into from
Sep 1, 2021
Merged

tag version 1.0.1 for pre release #546

merged 2 commits into from
Sep 1, 2021

Conversation

coderGo93
Copy link
Contributor

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Aug 30, 2021
@themantissa themantissa requested review from a team and threebee and removed request for a team September 1, 2021 16:30
themantissa
themantissa approved these changes Sep 1, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Hold merging till we resolve the last test issue.

thetonymaster
thetonymaster approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@thetonymaster thetonymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themantissa themantissa merged commit 72b4920 into master Sep 1, 2021
@thetonymaster thetonymaster deleted the changelog-pre-1.0.1 branch September 1, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetonymaster thetonymaster thetonymaster approved these changes

@themantissa themantissa themantissa approved these changes

@threebee threebee Awaiting requested review from threebee

Assignees

@coderGo93 coderGo93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coderGo93 @themantissa @thetonymaster