Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: remove misspell as a dependency #527

Merged
merged 6 commits into from
Aug 25, 2021
Merged

task: remove misspell as a dependency #527

merged 6 commits into from
Aug 25, 2021

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Aug 25, 2021

Description

golangci-lint already includes misspell, no need to include it as direct dependency

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

@gssbzn gssbzn requested a review from themantissa as a code owner August 25, 2021 13:22
@gssbzn
Copy link
Collaborator Author

gssbzn commented Aug 25, 2021

let's wait on #528 and a second PR to remove misspell from the website linting

- [Terraform](https://www.terraform.io/downloads.html) 0.12+
- [Go](https://golang.org/doc/install) 1.16 (to build the provider plugin)

# Developing the Provider
## Using the Provider
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general use before dev use

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@gssbzn gssbzn merged commit 80d250e into master Aug 25, 2021
@gssbzn gssbzn deleted the rm-misspell branch August 25, 2021 15:13
abner-dou pushed a commit to abner-dou/terraform-provider-mongodbatlas that referenced this pull request Aug 25, 2021
themantissa pushed a commit that referenced this pull request Aug 26, 2021
* fixed documentattion

* fix documentation

* typo fix

* changed examples in documentation

* added deprecated tags

* fix conflicts

* docs: added other example for ldap configuration docs (#520)

Co-authored-by: Edgar Lopez <[email protected]>

* fix documentation word in resources (#523)

* feat: use golangci lint action (#528)

* task: remove misspell as a dependency (#527)

* task: check examples are formatted correctly (#529)

* INTMDB-236: Updated the cluster configuration (#526)

* refactor: refactorized the examples for the cluster in tests/docs/examples

* comment

Co-authored-by: Edgar Lopez <[email protected]>

* fix deprecated docs

Co-authored-by: Edgar López <[email protected]>
Co-authored-by: Edgar Lopez <[email protected]>
Co-authored-by: Gustavo Bazan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants