-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task: remove misspell as a dependency #527
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let's wait on #528 and a second PR to remove misspell from the website linting |
gssbzn
commented
Aug 25, 2021
- [Terraform](https://www.terraform.io/downloads.html) 0.12+ | ||
- [Go](https://golang.org/doc/install) 1.16 (to build the provider plugin) | ||
|
||
# Developing the Provider | ||
## Using the Provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general use before dev use
themantissa
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
abner-dou
pushed a commit
to abner-dou/terraform-provider-mongodbatlas
that referenced
this pull request
Aug 25, 2021
themantissa
pushed a commit
that referenced
this pull request
Aug 26, 2021
* fixed documentattion * fix documentation * typo fix * changed examples in documentation * added deprecated tags * fix conflicts * docs: added other example for ldap configuration docs (#520) Co-authored-by: Edgar Lopez <[email protected]> * fix documentation word in resources (#523) * feat: use golangci lint action (#528) * task: remove misspell as a dependency (#527) * task: check examples are formatted correctly (#529) * INTMDB-236: Updated the cluster configuration (#526) * refactor: refactorized the examples for the cluster in tests/docs/examples * comment Co-authored-by: Edgar Lopez <[email protected]> * fix deprecated docs Co-authored-by: Edgar López <[email protected]> Co-authored-by: Edgar Lopez <[email protected]> Co-authored-by: Gustavo Bazan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
golangci-lint already includes misspell, no need to include it as direct dependency
Type of change:
Required Checklist: