Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stronger warning against attempting a shared tier upgrade #516

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

themantissa
Copy link
Collaborator

Description

Users who attempt to upgrade from a shared tier cluster (M2/M5) to a dedicated tier cluster - even though it is called out as unsupported - will destroy the shared tier and create a dedicated tier. This is due to the fact that upgrades are not supported yet Terraform will still try to make the changes it sees in the config. Adding stronger language to the call out that this is not supported since it will result in data lost from the shared tier cluster.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Users who attempt to upgrade from a shared tier cluster (M2/M5) to a dedicated tier cluster - even though it is called out as unsupported - will destroy the shared tier and create a dedicated tier.  This is due to the fact that upgrades are not supported yet Terraform will still try to make the changes it sees in the config.   Adding stronger language to the call out that this is not supported since it will result in data lost from the shared tier cluster.
@themantissa themantissa requested review from a team and threebee and removed request for a team August 16, 2021 22:55
Copy link

@threebee threebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@themantissa themantissa merged commit 1634562 into master Aug 17, 2021
@thetonymaster thetonymaster deleted the add-stronger-warning branch September 15, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants