Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 1.0.0-upgrade-guide.html.markdown #510

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Update 1.0.0-upgrade-guide.html.markdown #510

merged 2 commits into from
Aug 10, 2021

Conversation

themantissa
Copy link
Collaborator

Description

Add an intro paragraph to the upgrade guide.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • [ X ] Documentation fix/enhancement

Required Checklist:

  • [X ] I have signed the MongoDB CLA
  • [X ] I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • [X ] I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@themantissa themantissa requested review from coderGo93, abner-dou, a team and threebee and removed request for a team August 9, 2021 23:05
threebee
threebee approved these changes Aug 10, 2021
View reviewed changes
Copy link

@threebee threebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from already mentioned typo.

@themantissa themantissa requested a review from coderGo93 August 10, 2021 16:51
coderGo93
coderGo93 approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@themantissa themantissa merged commit 9e55f51 into master Aug 10, 2021
@themantissa themantissa deleted the upgrade-guide-intro branch August 10, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderGo93 coderGo93 coderGo93 approved these changes

@threebee threebee threebee approved these changes

@abner-dou abner-dou Awaiting requested review from abner-dou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@themantissa @threebee @coderGo93