INTMDB-232: Fix user agent version

[MihaiBojin]

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the Terraform contribution guidelines
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code

Further comments

Confirmed UA is now reported correctly (Splunk):

Repro

1. Create a file called main.tf

terraform {
  required_providers {
    mongodbatlas = {
      source = "localhost/mongodb/mongodbatlas"
      version = "1.0.0"
    }
  }
}

provider "mongodbatlas" {
  public_key = "..."
  private_key  = "..."
}


resource "mongodbatlas_project" "p0" {
  name   = "Project 0"
  org_id = "$ORG_ID"
}

2. Compile the provider and install it locally:

mkdir -p  ~/.terraform.d/plugins/localhost/mongodb/mongodbatlas/1.0.0/darwin_amd64
make build && mv ~/go/bin/terraform-provider-mongodbatlas ~/.terraform.d/plugins/localhost/mongodb/mongodbatlas/1.0.0/darwin_amd64/

3. Init the config and import a project (making a call to the API)

rm -rf .terraform .terraform.lock.hcl && terraform init &&  terraform import mongodbatlas_project.p0 $ORG_ID

Reported UA

[themantissa]

LGTM! Thank you so much @MihaiBojin

[MihaiBojin]

drive-by: golangci-lint is installed under bin/ - there's no point relying on the tool being available in the system path. cc @gssbzn in case I'm missing something

[gssbzn]

line 16 includes the bin folder in the PATH (export PATH := ./bin:$(PATH)) for convenience, no need to revert this just curious if that no longer works?

[MihaiBojin]

Didn't work for me on Mac, but it worked in GH actions

[MihaiBojin]

drive-by fix - unnecessary aliasing

[MihaiBojin]

moved under root / following the same directory structure as the AWS provider

[MihaiBojin]

ProviderVersion was not being replaced, without the full repo path being specified

[andreaangiolillo]

LGTM

[gssbzn]

[q] this is the user agent we do for the cli

var userAgent = fmt.Sprintf("%s/%s (%s;%s)", config.ToolName, version.Version, runtime.GOOS, runtime.GOARCH)

should we make something similar, ie: include os and arch?

[MihaiBojin]

Yeah that makes sense. Will update later, but if you want to make the change directly on the PR it would be even better, since I won't be in front of a computer for the next few hours. Thanks!

[MihaiBojin]

On second thought @gssbzn, if we made this change, the UA would be reported as:

 userAgent: terraform-provider-mongodbatlas/0.9.1-29-g13eb1636 (darwin;amd64) go-mongodbatlas/0.10.1 (darwin;amd64) 

(since we add the OS/ARCH via the go client)

[MihaiBojin]

I'm going to merge the PR as is / I don't think duplicating that info makes sense.

[gssbzn]

totally forgot we were doing that in the client, merge away

[gssbzn]

LGTM questions and clarifications are not blocking
Thanks fro fixing this