Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB Atlas - GCP VPC Peering example #490

Merged
merged 5 commits into from
Jul 7, 2021

Conversation

nikhil-mongo
Copy link
Collaborator

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@nikhil-mongo nikhil-mongo requested a review from themantissa July 1, 2021 06:51
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Just one change that's really blocking and that's the Azure mention :) Once that's fixed can approve. Thank you!

examples/MongoDB Atlas-GCP VPC Peering/Readme.md Outdated Show resolved Hide resolved
examples/MongoDB Atlas-GCP VPC Peering/cluster.tf Outdated Show resolved Hide resolved
@nikhil-mongo nikhil-mongo requested a review from themantissa July 3, 2021 01:11
Nikhil Singh added 2 commits July 3, 2021 11:39
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@themantissa themantissa merged commit 1b71b5b into mongodb:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants