Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-179: added more examples for connection strings #483

Merged
merged 2 commits into from
Jun 28, 2021
Merged

INTMDB-179: added more examples for connection strings #483

merged 2 commits into from
Jun 28, 2021

Conversation

coderGo93
Copy link
Contributor

Description

  • Added more examples for connections strings with output

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@themantissa themantissa requested review from a team and andreaangiolillo and removed request for a team June 25, 2021 00:26
@coderGo93 coderGo93 requested a review from threebee June 25, 2021 16:00
threebee
threebee approved these changes Jun 28, 2021
View reviewed changes
Copy link

@threebee threebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderGo93 coderGo93 merged commit 1e7553e into master Jun 28, 2021
@coderGo93 coderGo93 deleted the INTMDB-179 branch June 28, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetonymaster thetonymaster thetonymaster approved these changes

@threebee threebee threebee approved these changes

@themantissa themantissa Awaiting requested review from themantissa

@abner-dou abner-dou Awaiting requested review from abner-dou

@andreaangiolillo andreaangiolillo Awaiting requested review from andreaangiolillo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coderGo93 @threebee @thetonymaster